Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to embedded-hal 1.0. #37

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Update to embedded-hal 1.0. #37

merged 3 commits into from
Jan 30, 2024

Conversation

qwandor
Copy link
Contributor

@qwandor qwandor commented Jan 29, 2024

The biggest change here is that the new SpiDevice trait explicitly manages the CS pin, so we never need to manage it manually.

@qwandor
Update to embedded-hal 1.0.
b035f7f 
The biggest change here is that the new SpiDevice trait explicitly
manages the CS pin, so we never need to manage it manually.
almusil
almusil requested changes Jan 30, 2024
View reviewed changes
Copy link
Owner

@almusil almusil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

thank you for the PR. This is definitely an improvement. The change seems to be fine overall I have some minor comments inline.

examples/low_power_lab_receive.rs Outdated Show resolved Hide resolved
examples/low_power_lab_send.rs Outdated Show resolved Hide resolved
examples/receive.rs Show resolved Hide resolved
examples/send.rs Show resolved Hide resolved
almusil
almusil approved these changes Jan 30, 2024
View reviewed changes
Copy link
Owner

@almusil almusil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@almusil almusil merged commit 9338f74 into almusil:master Jan 30, 2024
3 checks passed
@qwandor qwandor deleted the embedded-hal branch January 30, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almusil almusil almusil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qwandor @almusil