Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure consequence.params.ignorePlurals can be deserialized from string #587

Open
aseure opened this issue Jun 2, 2020 · 0 comments
Open

Comments

@aseure
Copy link

aseure commented Jun 2, 2020

It was discovered that the Algolia Search API is sometimes returning the
ignorePlurals field from a Query Rule's consequence params field as a
string, such as:

"consequence": {
    "params": {
        "ignorePlurals": "false"
    }
}

Could you please ensure that the deserialization of query rules coming from
getRule, getRules, browseRules are correctly decoding those strings
without failing.

Also, like we did for other string-based booleans, it would be convenient to
convert the string to an actual boolean when the string is equal to "true" or
"false".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant