Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: deprecate YAML configuration #2685

Merged
merged 8 commits into from
Nov 28, 2024
Merged

fix!: deprecate YAML configuration #2685

merged 8 commits into from
Nov 28, 2024
+26 −0

Conversation

danielbrunt57
Copy link
Collaborator

@danielbrunt57 danielbrunt57 commented Nov 17, 2024 •
edited
Loading

YAML configuration is deprecated. Users must manually remove alexa_media from configuration.yaml file and add the integration via UI to avoid warning messages and future failure.

BREAKING CHANGE: Deprecate YAML configuration

@coveralls
Copy link

coveralls commented Nov 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12036745558

Details

  • 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 10.026%
Changes Missing Coverage Covered Lines Changed/Added Lines %
custom_components/alexa_media/init.py 1 3 33.33%
Totals Coverage Status
Change from base Build 11876654245: 0.02%
Covered Lines: 345
Relevant Lines: 3441
💛 - Coveralls

@danielbrunt57 danielbrunt57 changed the title breaking: deprecate YAML configuration fix: deprecate YAML configuration Nov 17, 2024
@danielbrunt57 danielbrunt57 changed the title fix: deprecate YAML configuration fix!: deprecate YAML configuration Nov 17, 2024
@danielbrunt57 danielbrunt57 mentioned this pull request Nov 18, 2024
Closed
@alandtse
Copy link
Owner

To be clear, the only changes to strings should be related to the deprecation.

@danielbrunt57
Copy link
Collaborator Author

danielbrunt57 commented Nov 20, 2024 •
edited
Loading

I was trying to 2nd guess how consecutive PR's work but I guess my thought process is wrong.
I was thinking that if strings is merged into Dev that the deprecated PR without the new strings changes your now updated Dev would basically undo the strings merge. I will edit my branch for deprecated and remove the duplication I added for the strings changes, if that's the required procedure. Just totally unclear how this sort of 2-step PR merge ends up working. To be clear, I forked your existing Dev and then created two separate branches for each PR but maybe that's the wrong process?

@danielbrunt57
Update strings.json: removed "restart_required"
f3e8a0d 
I thought I was going to implement it but I haven't yet.
Deleted:
    "restart_required": {
      "title": "Restart required",
      "fix_flow": {
        "step": {
          "confirm_restart": {
            "title": "Restart required",
            "description": "Restart of Home Assistant is required to finish download/update of {name}, click submit to restart now."
          }
        }
      }
    },
@alandtse alandtse merged commit e2a1444 into alandtse:dev Nov 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alandtse alandtse alandtse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielbrunt57 @coveralls @alandtse