fix: update strings.json #2681
fix: update strings.json #2681
Conversation
danielbrunt57
commented
Nov 16, 2024
•
danielbrunt57
commented
- Removed: services: clear_history
- Changed: miscellaneous wording changes
Added "issues" section in preparation for YAML deprecation
Reorder/reword as per original strings.json
2 more reversions to original
for more information, see https://pre-commit.ci
|
This seems to be tied to another PR if you're introducing a warning |
|
Yes, the |
|
So changes should be atomic. So any string changes for that pr should be in the PR. You shouldn't require two PRs to get the effect. |
|
Alright, I'll amend both PR's then... |
|
My thinking was that both PR's would be merged at the same time thus no harm. Or the strings PR merged first then the deprecated PR following that, but I'll conform... |
|
Also, after the other one goes through, please explain why you're updating the strings better. Update doesn't explain anything. If we needed to review this 3 months later, it doesn't explain what has changed any more than the fact a file has been changed. It forces someone to actually read the changes to guess what was intended. |
|
If you prefer, I can close my PR for deprecate and let you merge strings. Then I update my deprecate branch to your new dev and submit a new PR with new strings addition and config changes for deprecation... |
|
I'm going to close this one as it is basically just cosmetic + remove a deprecated section. |
