Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webapp: Could you please provide configurable base url? #8167

Closed
adux6991 opened this issue Nov 22, 2021 · 15 comments
Closed

Webapp: Could you please provide configurable base url? #8167

adux6991 opened this issue Nov 22, 2021 · 15 comments
Labels
area/frontend Related to the Airbyte webapp autoteam community kubernetes priority/low Low priority Stale team/tse Technical Support Engineers team/use type/enhancement New feature or request

Comments

@adux6991
Copy link

Tell us about the problem you're trying to solve

I deployed airbyte on K8s. Instead of kubectl port-forward, I used ingress and istio virtual service to make a url for airbyte webapp, like https://example.com/base/path/.

But it seems that airbyte webapp always assumes it is located at the root /, and I cannot find how to configure the webapp so that it knows its base url is /base/path/.

Describe the solution you’d like

Make base url configurable.

Describe the alternative you’ve considered or used

None.

Additional context

None.

Are you willing to submit a PR?

Sorry I'm not a frontend developer...

@adux6991 adux6991 added the type/enhancement New feature or request label Nov 22, 2021
@jrhizor jrhizor added the priority/low Low priority label Nov 29, 2021
@alafanechere alafanechere changed the title [webapp] Could you please provide configurable base url in webapp? Webapp: Could you please provide configurable base url in webapp? Nov 30, 2021
@alafanechere alafanechere changed the title Webapp: Could you please provide configurable base url in webapp? Webapp: Could you please provide configurable base url? Nov 30, 2021
@bleonard bleonard added autoteam area/frontend Related to the Airbyte webapp team/tse Technical Support Engineers labels Apr 26, 2022
@marcosmarxm marcosmarxm removed autoteam team/tse Technical Support Engineers labels Jun 14, 2022
@marcuslind90
Copy link

+1!
I have same need. I want to serve my application on Kubernetes using the Airbyte helm chart. I have /airflow/ /superset/ and I want /airbyte/, but Airbyte assume that it is / so all static files fail to load, and no way to configure base URL.

@abaerptc
Copy link
Contributor

abaerptc commented Oct 19, 2022

Any update on this? I need this as well, and it may block my use of Airbyte completely.

I see a PUBLIC_URL variable in airbyte-webapp/public/index.html, but it looks like this is a build-time variable, and not something we can set at deploy time. Is that correct?

Is there any way to accomplish this base url configuration when deploying via Helm chart?

@harshithmullapudi
Copy link
Contributor

Hey, @abaerptc had a word with the frontend team and it looks like we are currently not finding the bandwidth to get this up on the roadmap. I will follow up later in a couple of weeks and see if we can pick it up.

ptc-rhandler added a commit to ptc-rhandler/airbyte that referenced this issue Feb 16, 2023
* add `<base>` tag in index.html through nginx filter
* add basename configuration of
  react-router-dom BrowserRouter element
* modify `url()`s in index.css to use relative paths
* modify `fetch()`ing buildInfo.json to use relative
  url
* change vite configuration to use relative base
* add `BASE_URL` env variable
* add `webapp.baseUrl` helm value
@yepher
Copy link

yepher commented Apr 14, 2023

Please make this work

@nadalal
Copy link

nadalal commented Jun 13, 2023

Any update on this? It's such an integral issue and a blocker to even start using Airbyte properly. Is there anything we can do to move this forward?

@BoltMaud
Copy link

BoltMaud commented Aug 2, 2023

any update here ?

@hansesm
Copy link

hansesm commented Aug 30, 2023

is there a solution yet ?

@asafhm
Copy link

asafhm commented Sep 14, 2023

Would help a lot...

@octavia-squidington-iii
Copy link
Collaborator

At Airbyte, we seek to be clear about the project priorities and roadmap. This issue has not had any activity for 180 days, suggesting that it's not as critical as others. It's possible it has already been fixed. It is being marked as stale and will be closed in 20 days if there is no activity. To keep it open, please comment to let us know why it is important to you and if it is still reproducible on recent versions of Airbyte.

@octavia-squidington-iii
Copy link
Collaborator

This issue was closed because it has been inactive for 20 days since being marked as stale.

@cw-david-robinson
Copy link

Can we re-open this issue? This is an important feature that is currently blocking us from using Airbyte.

@prashantsengar-cl
Copy link

I second this. We would like to use Airbyte at our organization but are blocked due to the base url not being configurable.

@hansesm
Copy link

hansesm commented Jul 18, 2024

We still need a solution here. Its still not working on base urls.

please reopen

@BharadwajAd-Kore
Copy link

same we are trying to use but Base URL is not configurable any hack ?

@mrexhepi
Copy link

I have recreated the same issue , hope this will get resolved .
#48595

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp autoteam community kubernetes priority/low Low priority Stale team/tse Technical Support Engineers team/use type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests