New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: avoid shipping MockableMavericksView with release builds #672

Open

kenyee opened this issue Mar 1, 2023 · 0 comments

Contributor

kenyee commented Mar 1, 2023 •

edited

Loading

This is for these reasons:

don't want to include kotlin-reflect in release builds
don't want to include the MockMavericksPrinter in release builds (which uses kotlin-reflect)
don't want to expose the MockMavericksPrinter service in release builds (could avoid doing the registerMockPrinter call in release builds though)

I think mavericks-mocking would have to supply debug/release versions of MockableMavericksView...the release one would be a shell that does nothing...i.e. something like this: https://blog.dipien.com/how-to-organize-your-debug-and-release-android-code-255d7459521b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment