Don't request null keys from KVStore #774
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrooks-stripe
force-pushed
the
jbrooks-null-fetcher
branch
from
4235dd5 to
1d9aa1d
Compare
jbrooks-stripe
force-pushed
the
jbrooks-null-fetcher
branch
from
1d9aa1d to
889fd68
Compare
|
@jbrooks-stripe - might need a rebase of this branch |
piyushn-stripe
approved these changes
Jun 24, 2024
| @@ -141,4 +141,50 @@ class FetcherBaseTest extends MockitoSugar with Matchers { | |||
| actualRequest.get.name shouldBe query.groupByName + "." + query.columnName | |||
| actualRequest.get.keys shouldBe query.keyMapping.get | |||
| } | |||
|
|
|||
| @Test | |||
| def testParsingGroupByResponse_HappyHase(): Unit = { | |||
There was a problem hiding this comment.
nit:
s/HappyHase/HappyCase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the Fetcher to not include or attempt any requests when the keys are null.
Why / Goal
KVStore implementations are left up to consumers. In the case where null entries are being written out, this can lead to online/offline consistency issues. The GroupByUpload jobs are all setup to filter out any null keys, but the KVStore will still attempt to pull values if they exist. This adds parity with the null checks done in the GroupByUpload jobs to the online path and will exclude any attempt to pull values for null keys.
Test Plan
Checklist
Reviewers