You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Labels and descriptions should be plotted using the striplog axes object ax instead of plt.text(). In the case of multi axes plots, this may cause issues.
Also, we should allow the user to set the xposition of the text labels. Perhaps with an option to specify whether this is in data coordinates (which it is currently), or as a fraction of the x-axis (axis coordinates).
Currently an otherwise unspecified striplog will get a width of 1.5, so a label placement at 1.6 would correspond to a axis coordinate of 1.066. Using Axes coordinates could mean transforming the y-value from data coordinates (depth) into axes coordinates (0-1). So I'm not sure if that's unnecessarily complicated?
To avoid cluttering strip.plot(), perhaps it's best done as another method, say strip.plot_text(ax, xpos, name, size, wrap_width) ?
i.e. [ax.text(xpos, iv.middle, iv.primary['formation'], ha='left', va='center', size=10) for iv in w.data['strip']]
Labels and descriptions should be plotted using the striplog axes object
ax
instead ofplt.text()
. In the case of multi axes plots, this may cause issues.Also, we should allow the user to set the xposition of the text labels. Perhaps with an option to specify whether this is in data coordinates (which it is currently), or as a fraction of the x-axis (axis coordinates).
Currently an otherwise unspecified striplog will get a width of 1.5, so a label placement at 1.6 would correspond to a axis coordinate of 1.066. Using Axes coordinates could mean transforming the y-value from data coordinates (depth) into axes coordinates (0-1). So I'm not sure if that's unnecessarily complicated?
Relevant lines of code starts here.
striplog/striplog/striplog.py
Line 1684 in 96f399a
To avoid cluttering
strip.plot()
, perhaps it's best done as another method, saystrip.plot_text(ax, xpos, name, size, wrap_width)
?i.e.
[ax.text(xpos, iv.middle, iv.primary['formation'], ha='left', va='center', size=10) for iv in w.data['strip']]
Thanks for raising this issue @DougiB!
The text was updated successfully, but these errors were encountered: