Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission with duration > 32767 #43

Open
phw opened this issue Mar 8, 2019 · 1 comment
Open

Submission with duration > 32767 #43

phw opened this issue Mar 8, 2019 · 1 comment

Comments

@phw
Copy link
Contributor

phw commented Mar 8, 2019

Submitting a fingerprint for a duration > 32767 currently fails due to

if p['duration'] <= 0 or p['duration'] > 0x7fff:

Is this a strict limitation because that value gets used elsewhere as a signed integer, or could it be lifted? Maybe at least allow the size of an unsigned int with 32bits? The only real limitation I could immediately see is the schema using smallint, but I guess that could be easily set to integer.

See the related issue reported against Picard on https://tickets.metabrainz.org/browse/PICARD-1486

@phw
Copy link
Contributor Author

phw commented Dec 10, 2019

@lalinsky What do you think, could this be easily fixed server side (maybe just by changing the code above and probably adapting the database schema) or is there some bigger issue with this? How problematic is the schema change in regards to migration time and data size?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant