New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure `mask_generation` sampling avoids modulo bias #17

Open

omershlo opened this issue Oct 11, 2020 · 0 comments

Labels

help wanted security

Contributor

omershlo commented Oct 11, 2020

zk-paillier/src/zkproofs/correct_key_ni.rs

Line 112 in e3e3435

    
           let msklen = out_length / DIGEST_SIZE + 1; // adding one sha256 is more efficient then rejection sampling (see A.4 (e) in the paper)

(thanks to JP an team who raised this concern)

omershlo added help wanted security labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment