You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We found 2 issues with this during implementation that made us consider a manual implementation of serialize/deserialize for BTreeMaps or change the spec to match:
Validation rules for duplicates and order in the map are silently fixed by bincode deserialization (Implement the messages spec #114 (comment)). This could be a problem if we want to throw an error instead.
In #114 we automatically serialize/deserialize the
BTreeMap
s introduced by the messages spec (https://github.com/ZcashFoundation/redjubjub/blob/fa74969d5653c620e831c8c51c096f051527d958/rfcs/0001-messages.md#payloads)We found 2 issues with this during implementation that made us consider a manual implementation of serialize/deserialize for
BTreeMap
s or change the spec to match:bincode
deserialization (Implement the messages spec #114 (comment)). This could be a problem if we want to throw an error instead.BTreeMap
stores the length of itself in anu64
field when serialized usingbincode
. Spec says this should be anu8
(Implement the messages spec #114 (comment)).The text was updated successfully, but these errors were encountered: