Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frost-secp256k1-tr): add missing pub mod refresh and missing test #806

Merged

Conversation

StackOverflowExcept1on
Copy link
Contributor

@StackOverflowExcept1on StackOverflowExcept1on commented Dec 11, 2024

@conradoplg missed in #766
also fixes CI: cargo run --bin gencode -- --check

I'm sure how to fix warnings:

WARNING: documentation for aggregate_with_tweak is not available in base file. This can mean it's a specific type for the ciphersuite, or that there is a bug in gencode
WARNING: documentation for sign_with_tweak is not available in base file. This can mean it's a specific type for the ciphersuite, or that there is a bug in gencode
WARNING: documentation for Tweak is not available in base file. This can mean it's a specific type for the ciphersuite, or that there is a bug in gencode
WARNING: documentation for EvenY is not available in base file. This can mean it's a specific type for the ciphersuite, or that there is a bug in gencode

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.49%. Comparing base (5f4ac6e) to head (a7f2edc).
Report is 78 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #806      +/-   ##
==========================================
+ Coverage   82.18%   82.49%   +0.30%     
==========================================
  Files          31       41      +10     
  Lines        3188     4341    +1153     
==========================================
+ Hits         2620     3581     +961     
- Misses        568      760     +192     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The warnings are expected due to the ciphersuite-specific functions in the Taproot ciphersuite. I might eventually figure out a way for gencode to ignore those but it's fine for now.

@mergify mergify bot merged commit 061d1cb into ZcashFoundation:main Dec 11, 2024
20 checks passed
@StackOverflowExcept1on StackOverflowExcept1on deleted the fixes-secp256k1-tr branch December 11, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants