Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Read and display the computer description from Windows machines #6556

Open
tylla opened this issue Nov 25, 2024 · 9 comments
Assignees

Comments

@tylla
Copy link

tylla commented Nov 25, 2024

HI!
All windows computers have a "Computer description" field that can be set when one renames the computer. Actually Linux Samba has a similar "server string" entry. This field allows to enter extra information about the machine, and is some times unpopulated or contains some non-sense like "Kitchen computer", but it can be very well used for some really useful things like for example information about the location and/or user of the computer.

Currently MeshCentral doesn't use this value but it would be really nice to extract it and show it in the "My Devices" list and on the General tab of the machine overview.
Currently there is an "OS Name" and there could be an "OS Description" as well which would show this value.

If one would like to check the current value:
From the Windows GUI:

  1. Open File Explorer,
  2. Right-click This PC and choose Properties, and
  3. Click Change settings on the right

From the command line (cmd.exe):

  • wmic os get description
    or
  • reg query "HKLM\SYSTEM\CurrentControlSet\services\LanmanServer\Parameters" /v srvcomment

I tried to search for this feature in the open/closed issues, but couldn't find anything similar, I hope I didn't missed it. :)

Please indicate if I should provide any additional information, which I would happily provide.

@si458
Copy link
Collaborator

si458 commented Nov 25, 2024

Ah right, u are talking about the old style Computer Description inside the system properties panel!
Screenshot_20241125_165207_Firefox

@tylla
Copy link
Author

tylla commented Nov 27, 2024

Yep, exactly!
Thanks for including the screenshot, I should have done that, sorry.

@si458 si458 self-assigned this Nov 27, 2024
@si458
Copy link
Collaborator

si458 commented Nov 27, 2024

if you want me to add it into the Details tab,
i can add an entry under Operating System below Name saying Description
this way we can expand on it in future for other OS like linux

adding it into the General tab and then the list view is more fiddly because we already have Description
so it would cross the 2 over, ill have to think on it

@tylla
Copy link
Author

tylla commented Dec 4, 2024

Hmm, the Details tab is a fit place right under the Name entry.
OTOH on the General tab, an OS Description would be natural as well.
Actually if it's not a too big hurdle, I would be really happy to see it in both places as well. As the Name in the Details tab is listed in the General tab as OS Name, the same logic could be applied: Description - OS Description.

@si458
Copy link
Collaborator

si458 commented Dec 4, 2024

OK leave it with me to have a play with!
My thinking is we display OS description ONLY if u actually have one, if its blank then don't display it :)

@si458
Copy link
Collaborator

si458 commented Dec 6, 2024

so this is already included and u can access it using the websocket api (node.hardware.windows.osinfo.Descrption)
we just dont display it on the web ui, who knew haha!

i have included it in the Details tab only because the General tab uses a different set of results
and this would mean pushing i would have to query the info AGAIN just to display it in the General Tab which isnt ideal!

si458 added a commit that referenced this issue Dec 6, 2024
@tylla
Copy link
Author

tylla commented Dec 9, 2024

Wow, thank you very much. That was some real quick thing. I can't wait to test it.

I don't want to sound too demanding :), but is there a chance that at some point in the future the General tab will get this as well?

@si458
Copy link
Collaborator

si458 commented Dec 9, 2024

yes i will look at it in future but at the minute the way the code is setup, is basically
all the details tab is done when the meshagent starts up and then every 15mins
where as the general tab can change on the fly
so in a sense it would querying the twice which isnt idea!

IF you brave enough u can test it now using the development build (no translations tho so only english!)

  1. stop meshcentral,
  2. BACKUP ALL FOLDERS!!!
  3. npm install Ylianst/MeshCentral
  4. start meshcentral

or docker master images (translations included)
ghcr.io/ylianst/meshcentral:master

@tylla
Copy link
Author

tylla commented Dec 9, 2024

Ohh, that's perfect, I will wait with patience.

Well, it's a production environment, so I'm not that brave. But we will see it surely soon. :)

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants