Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default rpc_mem to false for bazel #710

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Default rpc_mem to false for bazel #710

wants to merge 4 commits into from

Conversation

gasgallo
Copy link
Contributor

Fixes #709.

@gasgallo gasgallo mentioned this pull request Jan 26, 2021
Closed
@lee-bin
Copy link
Member

lee-bin commented Jan 26, 2021

Thanks for the contribution!
However, as it will change the default behavior for qualcomm socs, there is something more that needs to done to make the change work.

  1. cmake should also be fixed so that they work the same way.
  2. Docs should be added to specify how to enable rpcmem for qualcomm socs.

@gasgallo
Copy link
Contributor Author

@lee-bin please check the new commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MACE v1.0.0] rpcmem_init failed on GPU
2 participants
@gasgallo @lee-bin