Adds margins to InfoPannel for older OS #544
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LiYanan2004 can you show me what this looks like on MacOS < 14? Thanks |
|
Unfortunately, I have no device running macOS 13. But that piece of code should look the same as the latest OS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR that has been closed without merging: #539
Based on #540, older OS still using padding around ScrollView which results in a hard clip. Technically, it's possible to add margins inside ScrollView, so, of course, older OS deserves that margin🤣.
The code here uses safe area to add margins which might be the same with the new margin API, but supports older OS.