Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all interning #179

Closed
theotherian opened this issue Nov 12, 2021 · 1 comment · Fixed by #180
Closed

Remove all interning #179

theotherian opened this issue Nov 12, 2021 · 1 comment · Fixed by #180
Assignees
Labels
bug Something isn't working
Milestone

Comments

@theotherian
Copy link
Collaborator

We're currently using Immutables interning for at least 3 types: Address, XAddress and XrpCurrencyAmount (all of which are in Wrappers in the model package).

Doing this causes a few issues:

We need to stop doing this. That said, this will cause backwards compatibility issues unless you have @Value.Immutable(builder = true) in your annotation (despite true being the default) as, at least in Wrappers, removing intern = true results in the builder() method disappearing.

@theotherian theotherian added the bug Something isn't working label Nov 12, 2021
@theotherian theotherian self-assigned this Nov 12, 2021
@theotherian
Copy link
Collaborator Author

From looking at the code, it appears to only be these three types.

@theotherian theotherian linked a pull request Nov 13, 2021 that will close this issue
@sappenin sappenin added this to the v2.x milestone Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants