Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support creating tickets directly in Zammad #13152

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Conversation

nijel
Copy link
Member

@nijel nijel commented Nov 29, 2024

Proposed changes

  • drops CSP exceptions on management page
  • nicer integration on management page
  • opt-in integration for concact and hosting forms

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@nijel nijel added this to the 5.9 milestone Nov 29, 2024
@nijel nijel requested a review from a team November 29, 2024 14:31
- drops CSP exceptions on management page
- nicer integration on management page
- opt-in integration for concact and hosting forms
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 70.09346% with 32 lines in your changes missing coverage. Please review.

Project coverage is 90.93%. Comparing base (fead975) to head (6d01cc0).
Report is 43 commits behind head on main.

Files with missing lines Patch % Lines
weblate/wladmin/views.py 39.13% 13 Missing and 1 partial ⚠️
weblate/utils/zammad.py 74.35% 8 Missing and 2 partials ⚠️
weblate/accounts/views.py 55.55% 6 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13152      +/-   ##
==========================================
- Coverage   90.96%   90.93%   -0.04%     
==========================================
  Files         599      601       +2     
  Lines       62060    62148      +88     
  Branches     6397     6404       +7     
==========================================
+ Hits        56454    56512      +58     
- Misses       3949     3975      +26     
- Partials     1657     1661       +4     
Files with missing lines Coverage Δ
weblate/billing/views.py 75.32% <ø> (ø)
weblate/middleware.py 82.66% <ø> (-0.48%) ⬇️
weblate/urls.py 82.50% <ø> (ø)
weblate/utils/models.py 100.00% <100.00%> (ø)
weblate/utils/tests/test_zammad.py 100.00% <100.00%> (ø)
weblate/accounts/views.py 83.81% <55.55%> (-0.51%) ⬇️
weblate/utils/zammad.py 74.35% <74.35%> (ø)
weblate/wladmin/views.py 67.69% <39.13%> (-2.38%) ⬇️

@nijel nijel merged commit 861027d into WeblateOrg:main Nov 29, 2024
30 of 33 checks passed
@nijel nijel deleted the zammad branch November 29, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant