feat: Machinery configuration via API #13056
Conversation
…figuration_via_API
…figuration_via_API
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
What I miss is support for removing a service.
Also the semantics is slightly different than with the other API endpoints.
How about:
PATCHwould change configuration for a single service. Setting it to blank would remove it.PUTwould replace configuration for all services.
| ) | ||
|
|
||
| if service is None or errors: | ||
| return Response({"errors": errors}, status=HTTP_400_BAD_REQUEST) |
Check warning
Code scanning / CodeQL
Information exposure through an exception Medium
| ) | ||
|
|
||
| if service is None or errors: | ||
| return Response({"errors": errors}, status=HTTP_400_BAD_REQUEST) |
Check warning
Code scanning / CodeQL
Information exposure through an exception Medium
There was a problem hiding this comment.
There are some errors in OpenAPI validation: https://github.com/WeblateOrg/weblate/pull/13056/checks (You can ignore the warnings, these were present before).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13056 +/- ##
==========================================
+ Coverage 90.92% 90.95% +0.03%
==========================================
Files 601 601
Lines 62143 62248 +105
Branches 6404 6415 +11
==========================================
+ Hits 56505 56620 +115
+ Misses 3976 3967 -9
+ Partials 1662 1661 -1
|
Proposed changes
/api/projects/{string:project}/machinery_settings/weblate.machinery.modelsto be used by both API based and command based configurationChecklist
Other information