-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
12700 dummy fields #12872
base: main
Are you sure you want to change the base?
12700 dummy fields #12872
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12872 +/- ##
==========================================
- Coverage 91.13% 91.12% -0.01%
==========================================
Files 597 597
Lines 61229 61233 +4
Branches 6350 6352 +2
==========================================
Hits 55798 55798
- Misses 3776 3778 +2
- Partials 1655 1657 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still doesn't handle the create() code path. Also when doing functional changes, please cover that with a test case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weblate
Proposed changes
Modified
__setattr__
inweblate.auth.models.py
to take the first name and last name attributes and pass them as full_name in extra data.Checklist
Other information
I struggled to replicate this issue through weblate. It seems that for
User.objects.get_or_create
with thedummy fields
in thedefaults
parameter via the django shell, it would requirefirst_name
andlast_name
to be properties in the User class as it seems this function bypasses the weblate framework. This seems redundant however as their already exists a 'full_name` property.