Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(WorkgroupSelectAutocomplete): Convert component to standalone #2017

Merged

Conversation

hirokiterashima
Copy link
Member

Changes

This pull request includes several changes to the workgroup-select-autocomplete component and its integration within the classroom monitor application. The main focus is on converting the component to a standalone module, updating import statements, and modifying access levels of class members.

Component Refactoring:

  • Converted WorkgroupSelectAutocompleteComponent to a standalone component by adding necessary imports and updating the @Component decorator.
  • Changed access levels of class members in WorkgroupSelectAutocompleteComponent and WorkgroupSelectComponent to protected for better encapsulation. [1] [2] [3] [4] [5] [6] [7]

Template and Style Changes:

  • Updated the template of WorkgroupSelectAutocompleteComponent to use Angular's *ngFor directive with trackBy function for better performance.

Integration Updates:

Test

  • Workgroup select dropdown works as before in various locations in the CM.

@hirokiterashima hirokiterashima added this to the Standalone Components milestone Dec 3, 2024
@hirokiterashima hirokiterashima self-assigned this Dec 3, 2024
@hirokiterashima hirokiterashima marked this pull request as ready for review December 3, 2024 22:44
@hirokiterashima hirokiterashima merged commit 6bd1d19 into develop Dec 3, 2024
4 of 5 checks passed
@hirokiterashima hirokiterashima deleted the convert-WorkgroupSelectAutoComplete-to-standalone branch December 3, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant