Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Authoring): Only allow certain add options for branch steps #1837

Conversation

geoffreykwan
Copy link
Member

@geoffreykwan geoffreykwan commented Jun 12, 2024

Changes

Only allow these add step options for the branch steps

Branch step

  • Add step before

Branch path step

  • Add step before
  • Add step after

Branch merge step

  • Add step after
  • Branch off this step

For regular steps the options should be

  • Add step before
  • Add step after
  • Branch off this step

Test

  • Make sure the correct add step options show up for the branch step, branch path steps, and branch merge step

Closes #1836

@geoffreykwan geoffreykwan self-assigned this Jun 12, 2024
@geoffreykwan geoffreykwan marked this pull request as ready for review June 12, 2024 23:52
@geoffreykwan geoffreykwan requested a review from breity June 12, 2024 23:53
Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality works well.

One issue I found is that if you add a step before a branch step that is the first step in the lesson, the new step is added to the end of the previous lesson, when it should be added to the beginning of the current lesson. I think this is an existing issue, not related to this PR.

I believe we also decided that we're going to move this functionality away from the "Add Step" button. The "Add Step" button will always add a step after and then we're going to add a "Branch Off This Step" icon button to the step list item itself. But I guess this will be an intermediate step? Hopefully it won't be too confusing for users.

@geoffreykwan geoffreykwan merged commit 8918c6f into issue-1745-add-branch-from-add-step-button Jun 19, 2024
@geoffreykwan geoffreykwan deleted the issue-1836-only-allow-certain-add-options-for-branch-steps branch June 19, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants