Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Project Authoring): don't open imported step #1414

Open
hirokiterashima opened this issue Sep 11, 2023 · 0 comments · May be fixed by #1415
Open

feat(Project Authoring): don't open imported step #1414

hirokiterashima opened this issue Sep 11, 2023 · 0 comments · May be fixed by #1415
Assignees
@hirokiterashima
Labels
enhancement New feature of any size or improvement (UI, performance, security)

Comments

@hirokiterashima
Copy link
Member

Right now, we open the newly-import step for editing if there was just one imported step. Instead, this should mimic add-new-step and take user back to the project authoring view.
@hirokiterashima hirokiterashima self-assigned this Sep 11, 2023
hirokiterashima added a commit that referenced this issue Sep 11, 2023
@hirokiterashima
feat(Project Authoring): don't open imported step for editing
0f68fd4 
#1414
@hirokiterashima hirokiterashima added the enhancement New feature of any size or improvement (UI, performance, security) label Sep 11, 2023
@hirokiterashima hirokiterashima moved this to Under Review in WISE Development Sep 11, 2023
@hirokiterashima hirokiterashima linked a pull request Sep 11, 2023 that will close this issue
Draft
hirokiterashima added a commit that referenced this issue Sep 19, 2023
@hirokiterashima
Refactor code: make ChooseImportStepLocation component extend
1a79a16 
ChooseNodeLocationComponent. This necessitated changes to make the
insertAfter() and insertInside() functions returns Promises.

#1414
@hirokiterashima hirokiterashima moved this from Under Review to In Progress in WISE Development Sep 19, 2023
@hirokiterashima hirokiterashima moved this from In Progress to Todo in WISE Development Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hirokiterashima hirokiterashima

Labels
enhancement New feature of any size or improvement (UI, performance, security)
Projects
WISE Development 2023-2024
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(Project Authoring): Don't open imported step for editing WISE-Community/WISE-Client
1 participant
@hirokiterashima