Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(TeacherProjectService): Move branch authoring code #1220

Open
hirokiterashima opened this issue May 2, 2023 · 0 comments · May be fixed by #1221
Open

refactor(TeacherProjectService): Move branch authoring code #1220

hirokiterashima opened this issue May 2, 2023 · 0 comments · May be fixed by #1221
Assignees
@hirokiterashima
Labels
Code Quality
Milestone
Tech Debt 17 -> 16

Comments

@hirokiterashima
Copy link
Member

  • In TeacherProjectService, move these code to NodeAdvancedBranchAuthoringComponent, where it's actually being called
    • setTransitionLogicField()
    • setTransition()
    • addBranchPathTakenConstraints()
  • Remove TeacherProjectService.isNodeIdUsed() since it's unused
  • Add private keyword and function return types in surrounding code
@hirokiterashima hirokiterashima added this to the Tech Debt 20 -> 19 milestone May 2, 2023
@hirokiterashima hirokiterashima self-assigned this May 2, 2023
hirokiterashima added a commit that referenced this issue May 2, 2023
@hirokiterashima
refactor(TeacherProjectService): Move branch authoring code
51a9428 
#1220
@hirokiterashima hirokiterashima linked a pull request May 2, 2023 that will close this issue
Draft
@breity breity moved this to Todo in WISE Development May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hirokiterashima hirokiterashima

Labels
Code Quality
Projects
WISE Development 2023-2024
Status: Todo
Milestone
Tech Debt 17 -> 16
Development

Successfully merging a pull request may close this issue.

refactor(TeacherProjectService): Move branch authoring code WISE-Community/WISE-Client
1 participant
@hirokiterashima