refactor(lbaaas): remove deprecated DNSName and NetworkUUID field

UpCloudLtd · Feb 29, 2024 · 5b6c6f6 · 5b6c6f6
1 parent 7be04bb
commit 5b6c6f6
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,9 @@ See updating [Changelog example here](https://keepachangelog.com/en/1.0.0/)
 
 ## [Unreleased]
 
+### Removed
+- **Breaking**, Managed Load Balancer: remove deprecated `DNSName` and `NetworkUUID` fields.
+
 ## [7.0.0]
 
 ### Added

diff --git a/upcloud/load_balancer.go b/upcloud/load_balancer.go
@@ -252,9 +252,7 @@ type LoadBalancer struct {
 	Name             string                       `json:"name,omitempty"`
 	Zone             string                       `json:"zone,omitempty"`
 	Plan             string                       `json:"plan,omitempty"`
-	NetworkUUID      string                       `json:"network_uuid,omitempty"` // deprecated
 	Networks         []LoadBalancerNetwork        `json:"networks,omitempty"`
-	DNSName          string                       `json:"dns_name,omitempty"` // deprecated
 	Labels           []Label                      `json:"labels,omitempty"`
 	ConfiguredStatus LoadBalancerConfiguredStatus `json:"configured_status,omitempty"`
 	OperationalState LoadBalancerOperationalState `json:"operational_state,omitempty"`

diff --git a/upcloud/load_balancer_test.go b/upcloud/load_balancer_test.go
@@ -13,7 +13,6 @@ func TestMarshalLoadBalancer(t *testing.T) {
 	[
 		{
 			"name": "example-service",
-			"network_uuid": "03631160-d57a-4926-ad48-a2f828229dcb",
 			"operational_state": "running",
 			"plan": "development",
 			"configured_status": "started",
@@ -145,8 +144,6 @@ func TestMarshalLoadBalancer(t *testing.T) {
 		Name:             "example-service",
 		Zone:             "fi-hel1",
 		Plan:             "development",
-		NetworkUUID:      "03631160-d57a-4926-ad48-a2f828229dcb",
-		DNSName:          "lb-0aff6dac143c43009b33ee2756f6592d.upcloudlb.com",
 		ConfiguredStatus: LoadBalancerConfiguredStatusStarted,
 		OperationalState: LoadBalancerOperationalStateRunning,
 		CreatedAt:        timeParse("2021-12-07T13:58:30.817272Z"),

diff --git a/upcloud/request/load_balancer.go b/upcloud/request/load_balancer.go
@@ -53,7 +53,6 @@ type CreateLoadBalancerRequest struct {
 	Name             string                               `json:"name,omitempty"`
 	Plan             string                               `json:"plan,omitempty"`
 	Zone             string                               `json:"zone,omitempty"`
-	NetworkUUID      string                               `json:"network_uuid,omitempty"`
 	Networks         []LoadBalancerNetwork                `json:"networks,omitempty"`
 	ConfiguredStatus upcloud.LoadBalancerConfiguredStatus `json:"configured_status,omitempty"`
 	Frontends        []LoadBalancerFrontend               `json:"frontends"`

diff --git a/upcloud/request/load_balancer_test.go b/upcloud/request/load_balancer_test.go
@@ -54,7 +54,6 @@ func TestCreateLoadBalancerRequest(t *testing.T) {
 		"name": "example-service",
 		"plan": "development",
 		"zone": "fi-hel1",
-		"network_uuid": "03631160-d57a-4926-ad48-a2f828229dcb",
 		"configured_status": "started",
 		"frontends": [
 			{
@@ -1392,7 +1391,6 @@ func TestCreateLoadBalancerLabelsRequest(t *testing.T) {
 		"name": "example-service",
 		"plan": "development",
 		"zone": "fi-hel1",
-		"network_uuid": "03631160-d57a-4926-ad48-a2f828229dcb",
 		"configured_status": "started",
 		"frontends": [],
 		"backends": [],