Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DungeonEscape: rotate multplier 200f should be m_PushBlockSettings.agentRotationSpeed I feel? #5850

Closed
hughperkins opened this issue Dec 22, 2022 · 2 comments · May be fixed by #5851
Closed

DungeonEscape: rotate multplier 200f should be m_PushBlockSettings.agentRotationSpeed I feel? #5850

hughperkins opened this issue Dec 22, 2022 · 2 comments · May be fixed by #5851
Labels
bug Issue describes a potential bug in ml-agents. stale Issues that have been idle for a while. Automatically closed by a bot if idle for too long.

Comments

@hughperkins
Copy link

Describe the bug

In DungeonEscape, push settings has attribute agentRotationSpeed available,

However in PushAgentEscape.cs, it uses hardcoded value 200f instead.

ml-agents/Project/Assets/ML-Agents/Examples/DungeonEscape/Scripts/PushAgentEscape.cs

Line 66 in 5b6cb98

transform.Rotate(rotateDir, Time.fixedDeltaTime * 200f);

I feel agentRotationSpeed should default to 200f, instead of 15, and the 200f should be replaced by m_PushBlockSettings.agentRotationSpeed?

To Reproduce
Go to github link

ml-agents/Project/Assets/ML-Agents/Examples/DungeonEscape/Scripts/PushAgentEscape.cs

Line 66 in 5b6cb98

transform.Rotate(rotateDir, Time.fixedDeltaTime * 200f);
. See the hardcoded constant.

Console logs / stack traces
N/A

Screenshots

ml-agents/Project/Assets/ML-Agents/Examples/DungeonEscape/Scripts/PushAgentEscape.cs

Line 66 in 5b6cb98

transform.Rotate(rotateDir, Time.fixedDeltaTime * 200f);

Environment (please complete the following information):
develop branch, and at least as far back as release_20
@hughperkins hughperkins added the bug Issue describes a potential bug in ml-agents. label Dec 22, 2022
hughperkins added a commit to hughperkins/ml-agents that referenced this issue Dec 22, 2022
@hughperkins
Change hard-coded 200f to m_PushBlockSettings.agentRotationSpeed; add…
a4b8e00 
…ress Unity-Technologies#5850
@hughperkins hughperkins mentioned this issue Dec 22, 2022
Open
10 tasks
@stale
Copy link

stale bot commented Jun 18, 2023

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issues that have been idle for a while. Automatically closed by a bot if idle for too long. label Jun 18, 2023
@hughperkins
Copy link
Author

this isnt completed. the value is still set to 200f, see

ml-agents/Project/Assets/ML-Agents/Examples/DungeonEscape/Scripts/PushAgentEscape.cs

Line 66 in 6203c7e

transform.Rotate(rotateDir, Time.fixedDeltaTime * 200f);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issue describes a potential bug in ml-agents. stale Issues that have been idle for a while. Automatically closed by a bot if idle for too long.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change hard-coded 200f to m_PushBlockSettings.agentRotationSpeed; add… hughperkins/ml-agents
2 participants
@hughperkins @miguelalonsojr