Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fuzzer use static methods to create arbitrary objects #2440

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

IlyaMuravjov
Copy link
Collaborator

Description

Now fuzzer can use both static methods and constructors to create instances of arbitrary types.

Fixes #2437

How to test

Automated tests

The proposed changes are verified with tests:
utbot-java-fuzzing/src/test/kotlin/org/utbot/fuzzing/JavaFuzzingTest.kt

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@@ -186,6 +186,12 @@ class AbstractsObjectValueProvider(
}
}

private fun findAccessibleCreators(description: FuzzedDescription, classId: ClassId): Sequence<ExecutableId> =
(classId.allConstructors + (classId.jClass.methods
.filter { it.isStatic && it.returnType.id.isSubtypeOf(classId) }
Copy link
Collaborator

@Markoutte Markoutte Jul 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you, please, check what will happen if generics are used? Something like:

class A<T> {
    public static A<String> getStringTyped() { return new A<>("Test") }
    private A(T value) {};
}

...

public void testedMethod(A<Integer> expected) { ... }

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will erroneously use getStringTyped() to create A<Integer>. I was assuming that java fuzzer doesn't attempt to fully respect generic types here, since similar issue could have been reproduced even before this pull request:

interface A<T> {
    T get();
}

class AImpl implements A<String> {
    @Override
    public String get() {
        return "Test";
    } 
}

...

public void testedMethod(A<Integer> expected) { ... }

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, I tried to fix it with #2451. Please, review it when it is possible. I think same can be done for this PR when 2451 is merged.

@IlyaMuravjov IlyaMuravjov force-pushed the ilya_m/fuzz_objects_with_static_method branch from 6d93b45 to 400f616 Compare July 26, 2023 13:53
@Markoutte Markoutte self-requested a review July 31, 2023 07:37
@IlyaMuravjov IlyaMuravjov marked this pull request as draft August 4, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java fuzzer can't create any values for types with no public constructor (e.g. LocalDateTime)
2 participants