Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataAxisFormats theme #363

Open
wdwatkins opened this issue Jun 29, 2016 · 10 comments
Open

dataAxisFormats theme #363

wdwatkins opened this issue Jun 29, 2016 · 10 comments

Comments

@wdwatkins
Copy link
Contributor

https://github.com/USGS-R/smwrGraphs/blob/master/inst/doc/DateAxisFormats.pdf

Split out from #5

@wdwatkins
Copy link
Contributor Author

I think this will need to be done outside the config file. I think it would be relatively simple to write a function to do this/return the axis tick mark locations though.

@lindsayplatt lindsayplatt modified the milestone: Sprint 3 Jul 5, 2016
@lindsayplatt lindsayplatt modified the milestone: 0.8.0 Sep 2, 2016
@wdwatkins
Copy link
Contributor Author

☝️ has this been addressed/thought about since then?

@lindsayplatt
Copy link

this issue? No, since it's been assigned to you. The config file stuff has been merged since this though #416

@ldecicco-USGS
Copy link
Member

I think this will need to be in a "theme". So, we can currently create config files that temporarily set par arguments, but the theme will allow a preset axis call (or whatever) which will allow this task to be done. I guess this means I have to get on #385. I'll try to get to that today/tomorrow.

@ldecicco-USGS ldecicco-USGS changed the title dataAxisFormats config dataAxisFormats theme Jan 18, 2017
@lindsayplatt
Copy link

Currently blocked by #134

@jiwalker-usgs
Copy link
Contributor

This should be unblocked now by using date_axis

@lindsayplatt
Copy link

What is left for this task? Sounds like we just need to document how to use it?

@lindsayplatt
Copy link

@wdwatkins @ldecicco-USGS ☝️

@ldecicco-USGS
Copy link
Member

I think actually create the theme is something that would need to be done.

@lindsayplatt
Copy link

OK, I'm marking this as an enhancement for now and moving out of the sprint since it's more than just documentation. Not needed to get this thing bug-free, but realize that it's the goal if this is going to be a more widely used package.

@lindsayplatt lindsayplatt removed this from the 0.8.0 milestone Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants