Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring Sass variables #414

Open
3 tasks
francisrupert opened this issue Apr 10, 2020 · 0 comments
Open
3 tasks

Refactoring Sass variables #414

francisrupert opened this issue Apr 10, 2020 · 0 comments
Labels
element: base element: branding element: color element: forms element: typography P4 source: internal FBCSS type: design type: feature request type: tooling
Milestone
The Fridge

Comments

@francisrupert
Copy link
Contributor

francisrupert commented Apr 10, 2020 •
edited
Loading

  • !default flag to initial global vars. While the use case should be rare, Sass variables should still be customizable; e.g. _fsa.variables.scss
  • Research if its relevant to do so for other variables. For example, component Sass files e.g. _fsa.buttons.scss.
  • Which variables declared in components should be moved to global?

(aside: there's a longer-term roadmap being drafted for Tokens, #415).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
element: base element: branding element: color element: forms element: typography P4 source: internal FBCSS type: design type: feature request type: tooling
Projects
None yet
Milestone
The Fridge
Development

No branches or pull requests
1 participant
@francisrupert