Node/NPM update implications

[francisrupert]

Background

We've managed to update FSA workstations' Node version, and thus can update most dependencies - most especially USWDS (#170).

[francisrupert]

@bignamehere,

Let me know what branch you've committed the peer dependencies you were playing around with @arosenblum, as well as what was accomplished.

I'll start to tackle this issue right away.

[bignamehere]

@francisrupert

still working on what is breaking the build... we have narrowed down one issue related to an "@" within a URL, and specifically @browserify /acorn5-object-spread.

I will continue to look into it.

[bignamehere]

@francisrupert & @arosenblum

I was able to npm install all dependencies (minus grunt-browserify) and it all went thru without issue.

Trying to downgrade browserify to 4.0.1 to see if that fixes and will continue to investigate.

[bignamehere]

@francisrupert & @arosenblum

I tried working my way thru the package.json file for FSA-Style and trying to find what was attempting to load @browserify/acorn5-object-spread, which is different than acorn5-object-spread that some dependencies reference as well.

I am not having any luck with finding what is trying to pull down this dependency, but believe it is either node-sass, browserify, or detect. But having gone in circles all day long, I could be completely wrong.

My vote is to scuttle the ship and build out a new version of the project with Webpack, eliminating the need for most of these dependencies.

thoughts?

[arosenblum]

Do you have the latest package.json changes in a branch somewhere I can check out and fiddle with?

[francisrupert]

@arosenblum,

He hasn't committed a branch for it. I suspect these dependency problems are specific to @bignamehere and his unique station's setup (and the whole downgrading Node he had to do). I don't have any problems installing and building from mine - and I'd guess nor would you.

Go ahead and test it out yourself: clone the repo, npm i from master, and validate my assumption.

-F

[francisrupert]

@arosenblum,

Actually, I should amend that: on Thursday I had to bump node-sass from 3.10.1 to 4.7.2 (latest), as 3.10.1 gave me an error along lines of "Your current environment doesn't support Node Sass..."

That error was new after updating my Node/NPM per spa-dev-tools-2.0.0.

[bignamehere]

@arosenblum I have it checked in here: hotfix/dep-fail

here is a screenshot of the error I get with this setup:

But I indeed have Visual Studio 2008 installed and it runs. ???

[bignamehere]

@francisrupert & @arosenblum

I found this... https://github.com/browserify/detective/blob/v5.0.2/package.json

It references the @ --> (at)browserify/acorn5-object-spread in the package.json file.

There is also a reference to it in this code... "var acorn = require('@browserify/acorn5-object-spread/inject')(require('acorn'));" that is located in the index.js file of detective.

[francisrupert]

I'm assuming the point of this issue may be eliminated once the Webpack-oriented issues are complete.

Moving to the Webpack Milestone, though not quite yet closing.

[whatnextjamie]

@bignamehere close this one too?