Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need trait mapping files updated to ontology terms #6

Open
jdeck88 opened this issue Nov 8, 2021 · 3 comments
Open

Need trait mapping files updated to ontology terms #6

jdeck88 opened this issue Nov 8, 2021 · 3 comments
Assignees

Comments

@jdeck88
Copy link

jdeck88 commented Nov 8, 2021

The directories mostly have a *traits.csv file which lists the columns variable_name and variable_desc.
this looks like, for example in the waterquality dataset:

variable_name,variable_desc
Aluminum,Concentration of Aluminum in water

However, the variable_desc should map the correct ontology label, e.g.:

variable_name,variable_desc
Aluminum,{concentration of elemental aluminium in liquid water}

This issue covers all of the directories, but especially usgs and waterquality.

@ramonawalls ramonawalls self-assigned this Nov 28, 2021
@ramonawalls
Copy link
Contributor

I am going to leave variable_desc as it, because it defines the variable (useful in some cases). I could add a new column for obo_label, which maps to SPRDIO, but do you need that @jdeck88 if the column SPRDIOterm already has the CURIE for the term? Which do you prefer, labels or IDs?

@jdeck88
Copy link
Author

jdeck88 commented Nov 29, 2021

either the CURIE or the label is fine... If using the CURIE it must match exactly the class name in the ontology (same as if you use label to match rdfs:label )

@ramonawalls
Copy link
Contributor

I created a new issue for this as a checklist. See issue #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants