Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code to include latest changes in TulipaEnergyModel v0.10.0 #58

Open
datejada opened this issue Oct 7, 2024 · 3 comments
Open
Labels
Type: addition Add something that doesn't exist Zone: code architecture Changes to the structure or fundamentals Zone: export & visualisation How data leaves model & is visualised

Comments

@datejada
Copy link
Member

datejada commented Oct 7, 2024

Description

The multi-year investment add the index year to the profiles data for TulipaEnergyModel v0.10.0.

So, we need to check how those changes affect TulipaClustering. Or show in a example how an user can use TulipaCLustering for multi-year investment profile data.

Validation and testing

No response

Motivation

No response

Target audience

No response

Can you help?

No response

@datejada datejada added Type: addition Add something that doesn't exist Zone: code architecture Changes to the structure or fundamentals Zone: export & visualisation How data leaves model & is visualised labels Oct 7, 2024
@greg-neustroev
Copy link
Collaborator

greg-neustroev commented Nov 11, 2024

The outputs now should include years, see the example. The profile_name column comes from assets-profiles.csv, while the year column comes from year-data.csv.

How do we link the two?

@greg-neustroev
Copy link
Collaborator

actually this is simpler.

We take a file with columns
profile_name, year, period, timestep, value
-OR-
profile_name, year, timestep, value

It produces the same table, but with period related with rep_period. If there was no period column, we first split the time steps into periods. See profiles-rep-periods.csv for an example of the output table. Additionally, tables rep-periods-data.csv and rep-periods-mapping.csv are produced.

The difference with the existing implementation, is that the unique profile identifier is not profile_name, but a tuple (profile_name, year).

@gnawin
Copy link
Member

gnawin commented Nov 18, 2024

@greg-neustroev things are moving fast...we are actually having discussions on the input format (Abel sent a message to all last week). So regarding this part, the current consensus is not to make any changes.

The difference with the existing implementation, is that the unique profile identifier is not profile_name, but a tuple (profile_name, year).

There should be no difference with the existing implementation. Sorry for the inconvenience!

EDIT: probably better only act if you wait until all the discussions are finished, and we talk again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: addition Add something that doesn't exist Zone: code architecture Changes to the structure or fundamentals Zone: export & visualisation How data leaves model & is visualised
Projects
None yet
Development

No branches or pull requests

3 participants