Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize CSS related to rendering of fragments #7284

Open
DeamonDev opened this issue Dec 5, 2024 · 0 comments
Open

Optimize CSS related to rendering of fragments #7284

DeamonDev opened this issue Dec 5, 2024 · 0 comments
Assignees
Labels

Comments

@DeamonDev
Copy link
Contributor

DeamonDev commented Dec 5, 2024

💥 Proposal

I noticed decreased performance while opening (big) fragments in designer since this PR: #6393. The problem occurs on google chrome browser and takes ~6 seconds to open fragment with ~30 nodes. The same fragment is opened on firefox with 0.5sec or even less. I analyzed this using Chrome's profiler and this is caused by using costly CSS selector introduced in mentioned PR:


cursor: draggable ? "grab" : "inherit",
"body:has(&:active) *": {
    cursor: draggable ? "grabbing" : "inherit",
},

I propose to exchange it with sth cheaper.

This Chrome's behavior is probably caused by the fact it uses single-threaded engine for computing layouts.

image

image

@DeamonDev DeamonDev self-assigned this Dec 5, 2024
@DeamonDev DeamonDev linked a pull request Dec 5, 2024 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant