Feat: subquery generator #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TjitsevdM
reviewed
Jan 2, 2024
TjitsevdM
approved these changes
Jan 2, 2024
There was a problem hiding this comment.
Looks good! I suggested an adjustment to the description of the discord retriever. For the rest, my only comment relates to your message at the beginning of this PR. Even with only discord integrated, the subquery generator is already useful since it can split complex user requests into multiple easier requests.
- We needed to apply the cohere embedding model in our codes. - The `subquery.py` updated based on little experiments (both embedding model and function output updated).
We have added the custom embed model support in its newer version.
TjitsevdM
approved these changes
Jan 4, 2024
we updated the library to the newest right version and we're chosed the right LLM for the guidance. note: the guidance_llm would create the subqueries.
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we're aiming to include the subquery generator for just the discord platform. (There's no use-case for this but including more platforms in the near future will make it useful)