-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/discord-forum retriever #27
Conversation
Such as discord & discourse.
- The previous version was having issues with generating results (empty results always).
def query_discord_auto_filter( | ||
community_id: str, | ||
query: str, | ||
similarity_top_k: int = 20, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the top_k for the summaries or or the raw messages? Ideally, we have a separate parameter for each (k1 and k2 in card description under low level design). Also, is there a place where the d parameter is passed to a function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for asking, The similarity_top_k
in for the query_discord_auto_filter
is the k2, I'll see how the k1 can be adjusted in the secondary search (which would be in the function query_discord
.
For the parameter d
I was thinking to just include all the given date
from metadata and not the time interval, which I'll fix and add based on the card.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The two missing (d
and k1
) parameters added and can be read from the .env
file. Please let me know if you had any more questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See added comments, the PR doesn't correspond fully to the card description but this is a good start!
also, now we can read the hyperparams from .env file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my comments so quickly. Everything looks good now. The discourse implementation will be very similar. You can see if you prefer to finish that first or if you'd like to start with 3c instead
Added the forum retriever