Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prov/cxi: PR#9791 breaks build on LUMI - Issue#9835 #17

Open
syskovprdap opened this issue Oct 8, 2024 · 1 comment
Open

prov/cxi: PR#9791 breaks build on LUMI - Issue#9835 #17

syskovprdap opened this issue Oct 8, 2024 · 1 comment

Comments

@syskovprdap
Copy link
Contributor

syskovprdap commented Oct 8, 2024

 

Hi all,

I am trying to build the cxi provider on LUMI. The update merged in #9791 breaks the build process because `lib-cxi` is too old.
I am using here the main branch with the patch suggested in #9789:
```bash
CC prov/cxi/test/multinode/prov_cxi_test_multinode_test_barrier-test_barrier.o
In file included from prov/cxi/test/multinode/test_coll.c:29:
./prov/cxi/include/cxip.h: In function 'cxip_cmdq_empty':
In file included from prov/cxi/test/multinode/multinode_frmwk.c:67:
./prov/cxi/include/cxip.h: In function 'cxip_cmdq_empty':
./prov/cxi/include/cxip.h:2799:16: warning: implicit declaration of function 'cxi_cq_empty'; did you mean 'cxi_eq_empty'? [-Wimplicit-function-declaration]
2799 | return cxi_cq_empty(cmdq->dev_cmdq);

^~~~~~~~~~~~
cxi_eq_empty
./prov/cxi/include/cxip.h:2799:16: warning: implicit declaration of function 'cxi_cq_empty'; did you mean 'cxi_eq_empty'? [-Wimplicit-function-declaration]
2799
return cxi_cq_empty(cmdq->dev_cmdq);
^~~~~~~~~~~~
cxi_eq_empty
In file included from prov/cxi/test/multinode/test_frmwk.c:28:
./prov/cxi/include/cxip.h: In function 'cxip_cmdq_empty':
./prov/cxi/include/cxip.h:2799:16: warning: implicit declaration of function 'cxi_cq_empty'; did you mean 'cxi_eq_empty'? [-Wimplicit-function-declaration]
2799
return cxi_cq_empty(cmdq->dev_cmdq);
^~~~~~~~~~~~
cxi_eq_empty
In file included from prov/cxi/test/multinode/multinode_frmwk.c:67:
./prov/cxi/include/cxip.h: In function 'cxip_cmdq_empty':
In file included from prov/cxi/test/multinode/test_barrier.c:51:
./prov/cxi/include/cxip.h: In function 'cxip_cmdq_empty':
./prov/cxi/include/cxip.h:2799:16: warning: implicit declaration of function 'cxi_cq_empty'; did you mean 'cxi_eq_empty'? [-Wimplicit-function-declaration]
2799
return cxi_cq_empty(cmdq->dev_cmdq);
^~~~~~~~~~~~
cxi_eq_empty
```

Here are the command used:
```
module load PrgEnv-gnu-amd
module load libfabric/1.15.2.0
./autogen.sh
./configure --enable-cxi --with-rocr=${ROCM_PATH} --with-json=${HOME}/json-c-json-c-0.13.1-20180305 --prefix=$(pwd)/_inst
make install -j
```
and the version of the relevant libs
```
rpm -qa | grep cxi
cray-libcxi-retry-handler-0.9-SSHOT2.0.2_20230428225319_d0f6cbe0189c.x86_64
cray-libcxi-devel-0.9-SSHOT2.0.2_20230428225319_d0f6cbe0189c.x86_64
cray-cxi-driver-devel-0.9-34.7__g22b90ec.SSHOT2.0.2.x86_64
cray-cxi-driver-kmp-cray_shasta_c-0.9_k5.14.21_150400.24.46_12.0.71-34.7__g22b90ec.SSHOT2.0.2.x86_64
cray-libcxi-dracut-0.9-SSHOT2.0.2_20230428225319_d0f6cbe0189c.x86_64
cray-libcxi-0.9-SSHOT2.0.2_20230428225319_d0f6cbe0189c.x86_64
cray-libcxi-utils-0.9-SSHOT2.0.2_20230428225319_d0f6cbe0189c.x86_64
cray-cxi-driver-udev-0.9-34.7__g22b90ec.SSHOT2.0.2.x86_64
```

I understand that the effort of open-sourcing `cxi` is tedious and that the versioning problem might not be resolved easily/quickly. This specific issue is intended to track the issues we currently face. In the mean time, I have reverted the changes, the branch is available here: https://github.com/thomasgillis/libfabric/tree/dev-cxi
With the revert of the PR, the code compiles correctly on LUMI

@syskovprdap
Copy link
Contributor Author

test comment with user details

@syskovprdap syskovprdap changed the title prov/cxi: PR#9791 breaks build on LUMI - Issue#9835 prov/cxi: PR#9791 breaks build on LUMI - Issue#9835 git test kovair Oct 15, 2024
@syskovprdap syskovprdap changed the title prov/cxi: PR#9791 breaks build on LUMI - Issue#9835 git test kovair prov/cxi: PR#9791 breaks build on LUMI - Issue#9835 Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant