Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How should terriajs-cesium types be handled #6

Open
nf-s opened this issue Oct 6, 2022 · 0 comments
Open

How should terriajs-cesium types be handled #6

nf-s opened this issue Oct 6, 2022 · 0 comments

Comments

@nf-s
Copy link

nf-s commented Oct 6, 2022 •
edited
Loading

One plugin has @types/cesium as a dependency. Not only are they incorrect types - the package also has cesium as a dependency. Which means that the TerriaMap which imports the plugin will have terriajs-cesium and cesium in node_modules.

From a quick inspection of build JS files (for TerriaMap with given plugin) - I couldn't find any references to node_modules/cesium - but it could cause future problems.

How should a plugin get access to terriajs-cesium types?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nf-s