Webpack 5 upgrade #718
Draft
Webpack 5 upgrade #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used the following command:
```
find lib/ -name '*.scss' -exec npx sass-migrator module {} \;
```
pjonsson
reviewed
Dec 5, 2024
| @@ -46,7 +29,7 @@ function createLoader() { | |||
|
|
|||
| polyfill(function () { | |||
| loadMainScript() | |||
| .catch(() => { | |||
| .catch((err) => { | |||
There was a problem hiding this comment.
Since this introduces an unused variable, I think it's better to call it _err to be consistent with naming of other unused variables.
pjonsson
reviewed
Dec 5, 2024
| viewState.disclaimerVisible = true; | ||
| }); | ||
| } | ||
| if (terria.configParameters.globalDisclaimer !== undefined) { |
There was a problem hiding this comment.
My impression for how TSification is done in TerriaJS is that defined() is replaced with isDefined(), so leaving the defined() should make it easier to convert this to TypeScript in the future.
pjonsson
reviewed
Dec 5, 2024
| "sass": "<1.80", | ||
| "sass-loader": "^10", | ||
| "sass": "^1.81.0", | ||
| "sass-loader": "^16.0.3", |
There was a problem hiding this comment.
Same comment as in TerriaJS, I think this requires bumping the engine version.
|
I looked through this and besides the things I commented on, the things that are there looks good to me. Would love to get webpack 5 merged soon so Trivy can stop shouting about critical security vulnerabilities. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes TerriaJS/terriajs#6998
Merge after TerriaJS/terriajs#7351