Add support for managing multiple TVs #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the following commands for managing the TVs in the configuration: * `alga tv add` (replacing `alga setup`) * `alga tv list` * `alga tv remove` * `alga tv rename` * `alga tv set-default` A new global option has also been added, which allows specifying which TV to send commands to on a command-by-command basis. It has to be used like `alga --tv <identifer> ...`. The WebSocket client code has been refactored as part of this, to make it easier to split up the use cases of adding a new TV (where a handshake shouldn't be performed) and sending regular commands to manage a TV. Tests has also been added for this part of the code. A new version of the configuration file format has been added and Alga will automatically migrate to it if an old configuration file format is detected. When this is done, the existing TV in the configuration will be assigned an identifier for "default".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the following commands for managing the TVs in the configuration:
alga tv add(replacingalga setup)alga tv listalga tv removealga tv renamealga tv set-defaultA new global option has also been added, which allows specifying which TV to send commands to on a command-by-command basis. It has to be used like
alga --tv <identifer> ....The WebSocket client code has been refactored as part of this, to make it easier to split up the use cases of adding a new TV (where a handshake shouldn't be performed) and sending regular commands to manage a TV. Tests has also been added for this part of the code.
A new version of the configuration file format has been added and Alga will automatically migrate to it if an old configuration file format is detected. When this is done, the existing TV in the configuration will be assigned an identifier for "default".
Fixes #83.