Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update required Python version #3313

Open
NiklasMM opened this issue Sep 20, 2024 · 3 comments
Open

Update required Python version #3313

NiklasMM opened this issue Sep 20, 2024 · 3 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@NiklasMM
Copy link

Documentation link

https://docs.tandoor.dev/install/manual/

Affected section

Installation

Other

No response

Issue description

The documentation for a manual install states the minimum required Python version is 3.9, which is no longer accurate. For example there is code in https://github.com/TandoorRecipes/recipes/blob/develop/cookbook/connectors/connector_manager.py using "match case" syntax which was introduced in 3.10.

Docker installs seem to use 3.12 and I could not find any other mention of a minimum version in the codebase. So I'm not sure what the minimum required version is.

It would be cool to update the documentation and maybe add the minimum version to the pyproject.toml

@NiklasMM NiklasMM added the documentation Improvements or additions to documentation label Sep 20, 2024
@vabene1111 vabene1111 added the good first issue Good for newcomers label Sep 23, 2024
@NiklasMM
Copy link
Author

I would obviously fix the documentation myself, but I really can't find out what the required version is. Can anyone help?

@vabene1111
Copy link
Collaborator

ah sorry, I think required is 3.10 as you found with the match case but I would just put 3.12 (with maybe a reference to the docker file) so people always use the tested latest version.

@mc-knife
Copy link

mc-knife commented Nov 26, 2024

if you want image upload to be working, then you need 3.12, according to this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants