feat(download): allow fetching model files with multiple partitions #3258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsxiaoys
reviewed
Oct 11, 2024
wsxiaoys
reviewed
Oct 11, 2024
wsxiaoys
reviewed
Oct 11, 2024
wsxiaoys
reviewed
Oct 11, 2024
wsxiaoys
reviewed
Oct 11, 2024
wsxiaoys
reviewed
Oct 11, 2024
zwpaper
force-pushed
the
roylee/download-multiple-model-files
branch
from
0d52e83 to
3ce0c48
Compare
wsxiaoys
reviewed
Oct 12, 2024
wsxiaoys
reviewed
Oct 12, 2024
umialpha
reviewed
Oct 14, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3258 +/- ##
==========================================
- Coverage 63.05% 62.93% -0.12%
==========================================
Files 186 187 +1
Lines 20268 20506 +238
==========================================
+ Hits 12779 12906 +127
- Misses 7489 7600 +111
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wsxiaoys
changed the title
wsxiaoys
requested changes
Oct 16, 2024
wsxiaoys
reviewed
Oct 18, 2024
zwpaper
force-pushed
the
roylee/download-multiple-model-files
branch
from
a2be452 to
d03e1bf
Compare
wsxiaoys
reviewed
Oct 20, 2024
| let model_path = self.get_model_path(name); | ||
| // get_model_path returns the entrypoint of the model, | ||
| // will look for the file with the prefix "00001-of-" | ||
| pub fn get_model_entry_path(&self, name: &str) -> Option<PathBuf> { |
There was a problem hiding this comment.
does this function have to be public? please also check newly added pub function in this struct.
There was a problem hiding this comment.
this is also used in llama-cpp-server
https://github.com/TabbyML/tabby/pull/3258/files#diff-7e6c7f751bfa100a469d7b7e1b68d567287a88df6425e2c8155333a229ecce59R282
wsxiaoys
reviewed
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is only for reviewing the changes onto #3216, I have also raise a PR for #3216: umialpha#1
I have fork the registry and add Qwen2.5-Coder, which has a 3 files model, could be test by: