Miliseconds for stats #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
force-pushed
the
miliseconds-for-stats
branch
3 times, most recently
from
dd7a49f
to
d6f32b3
Compare
nikophil
force-pushed
the
miliseconds-for-stats
branch
3 times, most recently
from
ce9d84f
to
1a7739c
Compare
nikophil
force-pushed
the
miliseconds-for-stats
branch
from
9c9e3d6
to
44c0001
Compare
store waiting_time in seconds+microseconds store handling_time in seconds+microseconds store failing_time in seconds+microseconds Fixed statistics computing Handle micro/milli seconds in twig time filter Tested retry behavior Fixed waiting_time for messages with delay
nikophil
force-pushed
the
miliseconds-for-stats
branch
from
44c0001
to
7211389
Compare
|
@nikophil @weaverryan any interest in getting this merged? we're looking to start using this bundle, but need this PR, as it removes the drivers (we use postgres which was not implemented) |
|
WDYT @nikophil - it's been a long time, but if you fix the conflicts, the tests ARE passing. It would probably be worth pushing this forward - it's still alpha, so I'm not too worried about potentially breaking some things. Note: we DO use this bundle on production already. |
|
@weaverryan i'm happy to rebase this is @nikophil is unavailable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #20
fixes #17
fixes #25
(waiting for #19 & #24 to be merged)