Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal from CRAN #52

Closed
mem48 opened this issue Oct 11, 2024 · 5 comments
Closed

Removal from CRAN #52

mem48 opened this issue Oct 11, 2024 · 5 comments

Comments

@mem48
Copy link

mem48 commented Oct 11, 2024

Hi, I've had an email from CRAN that my package (opentripplanner) will be removed because it depends on googlePolylines.

I can see the error only applies to clang on Linux. https://cran.r-project.org/web/checks/check_results_googlePolylines.html

Is there a plan to fix this before the CRAN deadline of 2024-10-24? Otherwise, I'll start looking for an alternative.

@mem48
Copy link
Author

mem48 commented Oct 11, 2024

The specific error is;

/home/hornik/tmp/R.check/r-devel-clang/Work/build/Packages/BH/include/boost/qvm/quat_traits.hpp:82:30: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
   82 |     quat_traits<Q>::template write_element_idx(i, q) = s;
      |                              ^
/home/hornik/tmp/R.check/r-devel-clang/Work/build/Packages/BH/include/boost/qvm/quat_traits.hpp:92:30: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
   92 |     quat_traits<Q>::template write_element_idx(i, q, s);
      |                              ^
2 errors generated.

@rCarto
Copy link

rCarto commented Oct 18, 2024

Hi,
I hope that googlePolylines will get an update soon. Its use in osrm has been a clear improvement in speed.

If it's not fixed, we will revert to using gepaf for the osrm package.
gepaf is lightweight but very slow compared to googlePolylines (see this issue: riatelab/osrm#71). This solution is therefore OK but not ideal.

My colleague @mthh is currently developing a package that uses Rust to perform the same tasks (gepafer). It's already working properly and it's fast 🚀 , but we haven't yet undertaken to publish it on CRAN (and in all probability it won't be before October 24).

@dcooley
Copy link
Collaborator

dcooley commented Oct 19, 2024

Hi @rCarto and @mem48 - thanks for posting; I've just got back from a 2 week vaction and haven't been responding to any mesages :)

but rest assured I'm aware of this and have been working / planning on implementing a fix before the deadline.

@dcooley
Copy link
Collaborator

dcooley commented Oct 20, 2024

For this fix (v0.8.5) I've removed the BH CRAN dependency and added all the headers as local files.

  • included the qvm fix
  • renamed some file names within the 100 char limit required by CRAN (e.g., the inst/include/boost is now inst/i/b, and all the #include <boost/... are now #include <b/ to match
  • removed any unnecessary headers
  • removed any use / reference to std::auto_ptr - this is not allowed by CRAN

@dcooley
Copy link
Collaborator

dcooley commented Oct 22, 2024

on CRAN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants