You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I work for BitBag company, and I’d like to suggest updating the Bootstrap version to Bootstrap 5. Additionally, I’ve come across a few issues that I believe need attention. To address these issues and the update, I’ve prepared a pull request with the necessary changes.
Here’s a summary of the proposed changes:
Bootstrap update
Due to conflict with bootstrap 5, I wanted to ask you, if it is ok to remove bootstrap.native library. Having both bootstrap 5 and bootstrap.native imported causes some components not work properly (e.g. dropdown).
Bugfixes
Fixed error 500 for search and filters (Sylius 1.12) - if there is at least one element in search result it throws error 500
Fixed error 500 for address book (Sylius 1.12) - if you delete address from address book it throws error 500
Fixed missing mobile taxon menu - the condition for displaying mobile menu was never met
Added missing images (footer and error pages)
You can view the pull request with the proposed changes here: #121
I would greatly appreciate it, if you could review and consider these changes. If you have any questions or suggestions, please don’t hesitate to let me know.
Additionally, if you prefer, I can split the bug fixes into separate pull requests to make the review process more manageable and modular.
Best regards,
Bartek from BitBag
The text was updated successfully, but these errors were encountered:
Hi,
I work for BitBag company, and I’d like to suggest updating the Bootstrap version to Bootstrap 5. Additionally, I’ve come across a few issues that I believe need attention. To address these issues and the update, I’ve prepared a pull request with the necessary changes.
Here’s a summary of the proposed changes:
You can view the pull request with the proposed changes here: #121
I would greatly appreciate it, if you could review and consider these changes. If you have any questions or suggestions, please don’t hesitate to let me know.
Additionally, if you prefer, I can split the bug fixes into separate pull requests to make the review process more manageable and modular.
Best regards,
Bartek from BitBag
The text was updated successfully, but these errors were encountered: