add ESLint to CI

.github/workflows/code_quality.yaml

@@ -48,5 +48,17 @@ jobs:
             - name: Composer - Update dependencies
               run: composer update --no-progress
 
+            - name: Yarn install
+              uses: borales/actions-yarn@v4
+              with:
+                  cmd: install
+                  dir: dev
+
+            - name: Yarn ESLint
+              uses: borales/actions-yarn@v4
+              with:
+                  cmd: lint
+                  dir: dev
+
             - name: TwigCS - Check
               run: vendor/bin/twigcs templates/ --severity error --display blocking --reporter githubAction

.gitignore

@@ -1,5 +1,3 @@
-/vendor/
-/node_modules
 /composer.lock
 
 /etc/build/*
@@ -10,8 +8,6 @@
 
 /.phpunit.result.cache
 /behat.yml
-/phpspec.yml
-/phpunit.xml
 
 ###> symfony/webpack-encore-bundle ###
 /node_modules/

assets/js/index.js

@@ -32,7 +32,7 @@ axios.defaults.headers.post['X-Requested-With'] = 'XMLHttpRequest';
 
 document.addEventListener('DOMContentLoaded', () => {
   // Lightbox
-  const glightbox = GLightbox({ selector: '.glightbox' });
+  GLightbox({ selector: '.glightbox' });
 
   // Add to cart
   document.querySelectorAll('[data-js-add-to-cart="form"]')

assets/js/sylius-api-toggle.js

@@ -17,6 +17,7 @@ const SyliusApiToggle = (el) => {
   const toggleableElement = document.querySelector('[data-js-login="form"]');
 
   const debounce = (callback, duration) => {
+    // eslint-disable-next-line
     let timeout = null;
 
     return (...args) => {

assets/js/sylius-variants-prices.js

@@ -40,10 +40,10 @@ const handleProductOptionsChange = function handleProductOptionsChange() {
 
 const handleProductVariantsChange = function handleProductVariantsChange() {
   document.querySelectorAll('[name="sylius_add_to_cart[cartItem][variant]"]').forEach((item) => {
-    item.addEventListener('change', (e) => {
+    item.addEventListener('change', () => {
       const priceElement = item.closest('tr').querySelector('[data-js-product-variant-price]');
       const price = priceElement.innerHTML;
-      
+
       document.querySelector('[data-js-product-price]').innerHTML = price;
 
       if (priceElement.hasAttribute('data-original-price')) {

dev/.eslintrc.cjs

@@ -0,0 +1,16 @@
+module.exports = {
+  root: true,
+  env: {
+    browser: true,
+    es2021: true,
+  },
+  extends: [
+    "eslint:recommended",
+  ],
+  parserOptions: {
+    sourceType: "module"
+  },
+  globals: {
+    Translator: 'readonly',
+  },
+};

dev/.gitignore

@@ -0,0 +1,2 @@
+node_modules/
+yarn-error.log

dev/package.json

@@ -0,0 +1,10 @@
+{
+  "name": "sylius-bootstrap-theme",
+  "license": "MIT",
+  "scripts": {
+    "lint": "eslint -c .eslintrc.cjs ../assets"
+  },
+  "devDependencies": {
+    "eslint": "^8.56.0"
+  }
+}