Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change dataset_ convention #58

Open
RickMoynihan opened this issue Dec 1, 2017 · 0 comments
Open

Change dataset_ convention #58

RickMoynihan opened this issue Dec 1, 2017 · 0 comments

Comments

@RickMoynihan
Copy link
Member

RickMoynihan commented Dec 1, 2017

The convention we have of prefixing dataset_ to dataset names is just a way of avoiding collisions on field names in graphql. An alternative (perhaps more elegant) approach would be to nest datasets under a dataset field, e.g. instead of:

{
  dataset_births { 
     description
  } 

  dataset earnings { 
     description
  }
}

We could do:

{ 
    dataset { 
       births { description } 
       earnings { description } 
    }
}

Obviously if graphql ever gets namespaces graphql/graphql-spec#163 we could use those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant