Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all "normal" actions to "default" #3104

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MatusGuy
Copy link
Member

@MatusGuy MatusGuy commented Nov 17, 2024

This will absolutely remove all sprite file inconsistencies between "normal" and "default". Seriously, what were they thinking!

Now that all files are consistent there should be no more weird cases with objects showing wrong actions or giving cryptic warnings.

Testers: Please test badguys like granito, goldbomb, etc. thoroughly

Copy link
Member

@weluvgoatz weluvgoatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, reviewed code, works good and fine.

Copy link
Member

@weluvgoatz weluvgoatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, I retested it properly and the movable trampoline gets stuck in the bouncing position and the stationary trampoline doesn't even enter its next action in this PR.

@MatusGuy MatusGuy requested a review from weluvgoatz November 24, 2024 11:27
@MatusGuy
Copy link
Member Author

Fixed that just now

@weluvgoatz
Copy link
Member

I just noticed that the bumper has the same issue.

@MatusGuy
Copy link
Member Author

MatusGuy commented Dec 7, 2024

I just noticed that the bumper has the same issue.

Can't reproduce this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants