fix(install): fail install if Otelcol is not running on darwin #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
force-pushed
the
fix/install-script/macos-status
branch
2 times, most recently
from
addd518 to
8a91dde
Compare
sumo-drosiek
reviewed
Dec 6, 2023
swiatekm
force-pushed
the
fix/install-script/macos-status
branch
from
8a91dde to
c72a138
Compare
Unfortunately, it's not that easy to check if Otelcol is failing on MacOS, as the state can briefly be |
swiatekm
force-pushed
the
fix/install-script/macos-status
branch
from
c72a138 to
3d5b9db
Compare
sumo-drosiek
approved these changes
Dec 7, 2023
swiatekm
force-pushed
the
fix/install-script/macos-status
branch
from
3d5b9db to
5af2cf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if the launchd task is running after installation, same as we do for systemd. Add an error message to both of these cases.
I think this also resolves #1361 - @astencel-sumo @sumo-drosiek can you have a look?