Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OpAmp throttling to opampextension #1712

Open
echlebek opened this issue Nov 27, 2024 · 0 comments
Open

Add support for OpAmp throttling to opampextension #1712

echlebek opened this issue Nov 27, 2024 · 0 comments

Comments

@echlebek
Copy link
Collaborator

We want the Sumo opamp agent to respond appropriately when the server tells it to throttle.

When a ServerToAgent message is received with an error whose type is "UNAVAILBLE", the opamp client should disconnect.
https://opentelemetry.io/docs/specs/opamp/#throttling

The opamp-go library leaves it to us as the agent developers to actually implement that. We are just logging an error at the moment: https://github.com/SumoLogic/sumologic-otel-collector/blob/main/pkg/extension/opampextension/opamp_agent.go#L167

That callback needs to be replaced with one that disconnects the session, and retries it after the RetryAfter amount sent in the error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant