Remove opamp remote config dir readable validation (#1385)

* remove opamp remote config dir readable validation Signed-off-by: Sean Porter <[email protected]> * changelog entry Signed-off-by: Sean Porter <[email protected]> --------- Signed-off-by: Sean Porter <[email protected]>
SumoLogic · Dec 13, 2023 · 8d723b4 · 8d723b4
1 parent 6f3f290
commit 8d723b4
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 12 deletions.
diff --git a/.changelog/1385.changed.txt b/.changelog/1385.changed.txt
@@ -0,0 +1 @@
+Removed OpAMP extension remote configuration directory readable validation.
diff --git a/pkg/extension/opampextension/config.go b/pkg/extension/opampextension/config.go
@@ -16,8 +16,6 @@ package opampextension
 
 import (
 	"errors"
-	"fmt"
-	"os"
 
 	"github.com/oklog/ulid/v2"
 	"go.opentelemetry.io/collector/component"
@@ -63,10 +61,5 @@ func (cfg *Config) Validate() error {
 		return errors.New("opamp remote_configuration_directory must be provided")
 	}
 
-	d := cfg.RemoteConfigurationDirectory
-	if _, err := os.Stat(d); err != nil {
-		return fmt.Errorf("opamp remote_configuration_directory %s must be readable: %v", d, err)
-	}
-
 	return nil
 }
diff --git a/pkg/extension/opampextension/config_test.go b/pkg/extension/opampextension/config_test.go
@@ -17,7 +17,6 @@ package opampextension
 import (
 	"os"
 	"path/filepath"
-	"strings"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -63,10 +62,6 @@ func TestConfigValidate(t *testing.T) {
 	require.Error(t, err)
 	assert.Equal(t, "opamp remote_configuration_directory must be provided", err.Error())
 
-	cfg.RemoteConfigurationDirectory = "/tmp/opamp.d"
-	err = cfg.Validate()
-	assert.True(t, strings.HasPrefix(err.Error(), "opamp remote_configuration_directory /tmp/opamp.d must be readable:"))
-
 	d, err := os.MkdirTemp("", "opamp.d")
 	assert.NoError(t, err)
 	defer os.RemoveAll(d)
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Removed OpAMP extension remote configuration directory readable validation.