case sensitivity on user emails

[mathis-marcotte]

might close StatCan/aaw#127 (must test ofc)

[Jose-Matsuda]

Ok I've done a fair bit of focused digging, please let me know if I am making any sense I can post a follow-up comment if not.

Few steps to find out where I am in knowledge

1. At the argocd layer we deploy kubeflow here using an applicationset
2. So we go to the referenced repoUrl
3. Search for anything kfam related and end up in this issue and it turns out that it is instead in some profilescomponent
4. So we look in our kustomization which references upstream.
5. And lo and behold it exists here

Next Steps in order to test the image.

So it appears that we did switch to using the upstream image. So we will need to

• build this access-management image in our branch
• Turn off autosync in argocd dev at the kubeflow application level in order to make an edit to the profiles-deployment Deployment to make a change to the image
  
• Refresh and try things out, see if it performs as expected
• Iff it does, we can make the change permanent by changing up the kustomize that deploys this, and bring it to Prod too (by making the change in the prod branch as well).

Other relevant information

Our fork of kubeflow is at version 1.3, so when we upgrade we will need to evaluate and check that everything works as intended.
We may want to hold off on deploying this fix to prod if that is the case.

[Jose-Matsuda]

There's a double build-push because I kept this case-sensitivity-emails in the branchname, will remove it and just keep it as the build on pr / push to stc-master.

But this issue of the docker build failing is a tad more concerning, will need to investigate

[Jose-Matsuda]

I can make it past the first failure by upgrading the golang version to be 1.17 like they do upstream but now have a new one at

oh might need to update go.mod

[mathis-marcotte]

The solution taken was to forcefully lowercase the emails on profile and rolebinding creation. Investigation was done to try to remove case sensitivity, but that assumption is really built into kubernetes.

A case that wasn't tested is situations where a user actually has capital letters in their email, since I personally didn't have an email like that to use.

[Jose-Matsuda]

lgtm, as stated unsure about "how profiles already created with capital letters in it will act. If they don't actually work as expected, it might be either return to the drawing board or probably a better option would just be to fix it case by case in the profile objects already saved".

We might need to make a script to lowercase all the existing Profile and User crds to make sure they are compatible with this cross-cutting change.